Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karlburke/indexing efficiencies round2 #53

Closed
wants to merge 2 commits into from

Conversation

kburke
Copy link

@kburke kburke commented Apr 16, 2024

Clean up remaining ontology-api references now that display_subtype is calculated in entity-api rather than HuBMAP's search-api.

yuanzhou and others added 2 commits December 15, 2023 11:46
…nger needed for ontology-api access now that display_subtype is calculated in entity-api.
@kburke kburke requested a review from yuanzhou as a code owner April 16, 2024 20:38
@yuanzhou
Copy link
Member

@maxsibilla @libpitt @tjmadonna can you help confirm that this change doesn't affect the SenNet search-api?

@yuanzhou
Copy link
Member

Had to revert back, this PR no longer needed

@yuanzhou yuanzhou closed this Apr 18, 2024
@maxsibilla
Copy link
Contributor

@yuanzhou I don't think we need self.ONTOLOGY_API_BASE_URL anymore. In the main of the SenNet Search API we initialize our connection to UBKG and pass that instance to the Search Adaptor SearchAPI class

@yuanzhou
Copy link
Member

Good to know, thanks @maxsibilla

@yuanzhou yuanzhou deleted the karlburke/indexingEfficienciesRound2 branch May 6, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants