Abandon YAML for indexing, using UBKG #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionSupport Karlburke/search ap ir index collection support
yuanzhou
requested changes
Dec 13, 2023
src/app.py
Outdated
| @@ -1257,7 +1257,7 @@ def create_request_headers_for_auth(self, token): | |||
|
|
|||
| def init_translator(self, token): | |||
| if self.ubkg_instance is None: | |||
| return self.translator_module.Translator(self.INDICES, self.APP_CLIENT_ID, self.APP_CLIENT_SECRET, token, self.ONTOLOGY_API_APP_SETTING) | |||
| return self.translator_module.Translator(self.INDICES, self.APP_CLIENT_ID, self.APP_CLIENT_SECRET, token) | |||
There was a problem hiding this comment.
@kburke what I really meant is to replace this ONTOLOGY_API_APP_SETTING dict with a ONTOLOGY_API_URL and only use the application_context from constant.
SenNet introduced this ubkg_instance from the https://github.com/x-atlas-consortia/commons package, which is not a good design and will probably change down the road. So I don't want to broadcast this to HuBMAP.
yuanzhou
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove YAML file usage support functions. Set HM Translator to access ontology-api.