Fixed a bug where a 500 error would occur when any optional parameter…

… was used in the parameterized search. This happened because 'produce_manifest.lower() == true' would run if request.args has any arguments, but didn't check explicitly for produce-clt-manifest. Also, fixed an existing bug that would cause a 500 if any status code but 200 was returned by opensearch because len was applied to the method opensearch_response.json rather than the actual json opensearch_response.json()

src/app.py

@@ -472,7 +472,7 @@ def param_search_index(self, plural_entity_type):
                 produce_manifest = request.args.get('produce-clt-manifest')
                 json_query_dict['query']['bool']['must'] = [item for item in json_query_dict['query']['bool']['must'] if not ('match_phrase' in item and 'produce-clt-manifest.keyword' in item['match_phrase'])]
 
-                if produce_manifest.lower() == "true":
+                if produce_manifest and produce_manifest.lower() == "true":
                     generate_manifest = True
 
             # The following usage of execute_opensearch_query() followed by size_response_for_gateway() replaces
@@ -547,7 +547,7 @@ def param_search_index(self, plural_entity_type):
             else:
                 logger.error(f"Unable to return ['hits']['hits'] content of opensearch_response with"
                              f" status_code={opensearch_response.status_code}"
-                             f" and len(json)={len(opensearch_response.json)}.")
+                             f" and len(json)={len(opensearch_response.json())}.")
                 raise Exception(f"OpenSearch query return a status code of '{opensearch_response.status_code}'."
                                 f" See logs.")
         except Exception as e: