From cbab85b6fcb69284a4202588ccc3b250b720a625 Mon Sep 17 00:00:00 2001 From: amersharif Date: Mon, 26 Aug 2019 15:02:58 +0200 Subject: [PATCH 1/2] fix(AdSettingsCog): Change from div to button --- src/atoms/AdSettingsCog.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/atoms/AdSettingsCog.js b/src/atoms/AdSettingsCog.js index 86daaf40b..83fde1fdb 100644 --- a/src/atoms/AdSettingsCog.js +++ b/src/atoms/AdSettingsCog.js @@ -3,7 +3,7 @@ import styled from '@emotion/styled'; import { getColor, getVariable } from '../utils'; import { SvgIcon } from './SvgIcon'; -const StyledCog = styled.div` +const StyledCog = styled.button` position: absolute; left: 0; top: 0; @@ -13,6 +13,7 @@ const StyledCog = styled.div` filter: alpha(opacity=50); line-height: 0; cursor: pointer; + border-width: 0px; `; const AdSettingsCog = props => ( From 19fdc5c334c4fc5c68280ee3062203ee0ee0192a Mon Sep 17 00:00:00 2001 From: amersharif Date: Mon, 26 Aug 2019 15:18:15 +0200 Subject: [PATCH 2/2] svgIconWrapper: Change from div to span --- src/atoms/SvgIcon/SvgIconWrapper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/atoms/SvgIcon/SvgIconWrapper.js b/src/atoms/SvgIcon/SvgIconWrapper.js index 6b2b74d01..ea547f9d8 100644 --- a/src/atoms/SvgIcon/SvgIconWrapper.js +++ b/src/atoms/SvgIcon/SvgIconWrapper.js @@ -1,6 +1,6 @@ import styled from '@emotion/styled'; -const SvgIconWrapper = styled('div', { +const SvgIconWrapper = styled('span', { shouldForwardProp: prop => prop !== 'size', })` display: inline-block;