Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing naming in model.py #9

Open
c-flaherty opened this issue Sep 4, 2018 · 0 comments
Open

Editing naming in model.py #9

c-flaherty opened this issue Sep 4, 2018 · 0 comments

Comments

@c-flaherty
Copy link
Collaborator

c-flaherty commented Sep 4, 2018

  • Rename validation_score variable to cross_validation_score in model.py
  • Rename cross_validation_score function to run_cross_validation
  • Create a set_model_info function to be run inside run_model. Remove setting model info from get_model function
  • We currently refer to all regression and classification models as "estimators". Research whether or not this is the correct term
  • In class DataSet -> def clean_data, rename replace_data argument to in-place
  • Remove print_model, add flag print=False flag to get_model to optionally print
  • Move submit function to a utility class
  • Throw a TypeError instead of general Exception in BlenderModel
@c-flaherty c-flaherty changed the title Rename validation_score to cross_validation_score in model.py Editing naming in model.py Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant