Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoginResponse objects different to request the playlist and the art? #24

Open
daxcurson opened this issue Sep 2, 2021 · 1 comment
Open
Assignees

Comments

@daxcurson
Copy link
Owner

Due to different loginResponse objects being picked up for getting the playlist and the art, the playlist is working while the art is not. Log example:

192.168.1.6 - - [02/Sep/2021:07:15:22 -0300] "GET /ampache/server/json.server.php?action=playlist_songs&auth=b2b7a8585dcdd75b7278fcaee02296f6&filter=9&offset=0&limit=2147483647 HTTP/1.1" 200 319163 "-" "okhttp/3.14.9"
192.168.1.6 - - [02/Sep/2021:07:15:23 -0300] "GET /ampache/image.php?object_id=2142&object_type=album&auth=b2b7a8585dcdd75b7278fcaee02296f6&name=art.jpg HTTP/1.1" 200 94566 "-" "okhttp/3.14.9"
192.168.1.6 - - [02/Sep/2021:07:15:26 -0300] "GET /ampache/server/json.server.php?action=get_art&auth=caa17cbc32bbc40a258311ec75183818&type=artist&id=222 HTTP/1.1" 200 84 "-" "okhttp/3.14.9"

The invalid ID is that for the art, which causes the background to be blank. We seriously need some way to update login response if they are found to be outdated...

@daxcurson daxcurson self-assigned this Sep 2, 2021
@daxcurson daxcurson added this to the Initial Version milestone Sep 2, 2021
@daxcurson
Copy link
Owner Author

This has been investigated, the login response is successfully renewed if the session is expired while music is being played. The Player generates an error that is captured and in case it is a session expired, a request to renew the session is sent via a Broadcast message to the MainActivity. A similar solution could be applied to the crashing problem with the scroll list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant