Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Polyphone determines sf3 soundfonts via the filename, not the soundfont version #200

Closed
spessasus opened this issue Jul 25, 2024 · 1 comment

Comments

@spessasus
Copy link
Contributor

spessasus commented Jul 25, 2024

The issue

Polyphone decompresses the soundfont only if the filename extension is sf3. It doesn't check ifil like it should. (Or check sample type). This causes soundfont3 soundfonts saved with a .sf2 extension to be broken.

SoundFont3 Format

How to reproduce

  1. Grab this sf2 file and open it
  2. Navigate to samples
  3. Audio is completely broken
  4. Rename extension to "sf3"
  5. Reopen and navigate to samples
  6. Audio is fixed

Expected behavior

Polyphone should check if ifil is 3 instead of filename extension. That or check if (sampleType & 0x10) > 1

Version tested

2.3.1 (Flatpak)

@spessasus spessasus changed the title [BUG]Polyphone determines sf3 soundfonts via the filename [BUG] Polyphone determines sf3 soundfonts via the filename, not the soundfont version Jul 25, 2024
@davy7125
Copy link
Owner

I close this ticket since it be part of the job done in #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants