Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very similar to Query Engine #6

Open
balupton opened this issue May 2, 2012 · 10 comments
Open

Very similar to Query Engine #6

balupton opened this issue May 2, 2012 · 10 comments

Comments

@balupton
Copy link

balupton commented May 2, 2012

Very similar to Query Engine perhaps we should team up :) What are your thoughts?

Here is a comparison that I've done up:

  • Backbone Query
    • good readme documentation
    • runs on node.js and in the browser
    • supports NoSQL queries (similar to MongoDB etc)
  • Query Engine
    • includes live interactive demo
    • source-code documentation only
    • runs on node.js and in the browser
    • supports NoSQL queries (similar to MongoDB etc)
    • supports filters (applying a filter function to a collection)
    • supports search strings (useful for turning search input fields into useful queries)
    • supports pills for search strings (e.g. author:ben priority:important)
    • supports optional live collections (when a model is changed, added or removed, it can automatically be tested against the collections queries, filters, and search string, if it fails, remove it from the collection)
    • supports parent and child collections (when a parent collection has a model removed, it is removed from the child collection too, when a parent collection has a model added or changed, it is retested against the child collection)
@davidgtonge
Copy link
Owner

Hi, would be good to team up. I love what you've done with live collections.
Query Engine definitely has more features although there are some from Backbone Query that we could perhaps port over, eg. querying computed properties, querying nested models / arrays.

What do you think is the best way to move forward ?

@balupton
Copy link
Author

balupton commented May 9, 2012

Hey David,

Thanks for your kind words. I definitely agree with you that porting over the missing functionality from Backbone Query into Query Engine makes the most sense (least effort, biggest reward).

In regards to who actually does the porting, it doesn't seem that particular, as long as we make ourselves available to each other to help out if someone gets stuck. On that note, you can add me on Skype (username balupton) or join the #bevry on freenode channel if you prefer IRC.

I've created the repo - https://github.com/balupton/query-engine-contrib - for us to work on (you've been added a contributor), so let's use a new branch called backbone-query-merge to do the porting. Once it's all stable, we'll pull the changes into the official repository :)

Good plan? Really excited about working together on this! :D Can't wait for the end result, it'll be spectacular!

@davidgtonge
Copy link
Owner

Hi Benjamin,

Thanks for the message. I'll have a look at porting some of the code over this weekend. Will try and connect via Skype / IRC also.

Thanks again

Dave

@davidgtonge
Copy link
Owner

Hi Benjamin,

I've had a look at the code this morning and think it would be good to chat about some of the code.
What times are you normally available on Skype / IRC? Thanks.
Before doing too much work on the code, I've been comparing the performance of the 2 libraries - food for thought:
http://jsperf.com/backbone-query-vs-queryengine/2

@balupton
Copy link
Author

Cool, looks like you made it a lot faster! Keen to see what you did.

I'm generally on Skype everyday from 10am to 10pm Sydney Time. However, can be on earlier (6am+) if need be.

@balupton
Copy link
Author

Cool, I've merged that branch into the bevry repo. And just pushed v1.2.2 that adds the missing functionality from backbone query into query engine.

Didn't apply the refactorings around the query class, as wasn't sure what benefit they added...

@balupton
Copy link
Author

I've updated the performance tests. QueryEngine same results. So I guess the refactorings you've done where for the speed increase... Will look into this some more.

@davidgtonge
Copy link
Owner

Hi, thanks for doing the merge. I've been on holiday, but should be able to help out a bit more now.
I'll take a look at the code shortly.

@charlotte-miller
Copy link

Hey David - are you going to continue using and working on backbone_query?

@davidgtonge
Copy link
Owner

Hi Chip, yes I'm using backbone_query in production. I have some updates that I need to push and will do so shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants