-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very similar to Query Engine #6
Comments
Hi, would be good to team up. I love what you've done with live collections. What do you think is the best way to move forward ? |
Hey David, Thanks for your kind words. I definitely agree with you that porting over the missing functionality from Backbone Query into Query Engine makes the most sense (least effort, biggest reward). In regards to who actually does the porting, it doesn't seem that particular, as long as we make ourselves available to each other to help out if someone gets stuck. On that note, you can add me on Skype (username balupton) or join the #bevry on freenode channel if you prefer IRC. I've created the repo - https://github.com/balupton/query-engine-contrib - for us to work on (you've been added a contributor), so let's use a new branch called Good plan? Really excited about working together on this! :D Can't wait for the end result, it'll be spectacular! |
Hi Benjamin, Thanks for the message. I'll have a look at porting some of the code over this weekend. Will try and connect via Skype / IRC also. Thanks again Dave |
Hi Benjamin, I've had a look at the code this morning and think it would be good to chat about some of the code. |
Cool, looks like you made it a lot faster! Keen to see what you did. I'm generally on Skype everyday from 10am to 10pm Sydney Time. However, can be on earlier (6am+) if need be. |
Cool, I've merged that branch into the bevry repo. And just pushed v1.2.2 that adds the missing functionality from backbone query into query engine. Didn't apply the refactorings around the query class, as wasn't sure what benefit they added... |
I've updated the performance tests. QueryEngine same results. So I guess the refactorings you've done where for the speed increase... Will look into this some more. |
Hi, thanks for doing the merge. I've been on holiday, but should be able to help out a bit more now. |
Hey David - are you going to continue using and working on backbone_query? |
Hi Chip, yes I'm using backbone_query in production. I have some updates that I need to push and will do so shortly. |
Very similar to Query Engine perhaps we should team up :) What are your thoughts?
Here is a comparison that I've done up:
author:ben priority:important
)The text was updated successfully, but these errors were encountered: