Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total games not record not accurate - some games not being saved. #7

Open
mgrpowers opened this issue Jun 14, 2018 · 1 comment
Open

Comments

@mgrpowers
Copy link

mgrpowers commented Jun 14, 2018

It appears when a doubles match is played, the record of 1 or more players is not saved. I haven't dug into the logging yet.

@Josh-Arment
Copy link

Full disclosure: I have no idea what I'm doing.

That said, I believe lines 758-765 in js/source/tablechamp.js are responsible for the error.

For example, line 758 reads
var t1p1GamesLost = localData.playersByKey[t1p1Key].singles_lost;

I believe line 758 should read
var t1p1GamesLost = localData.playersByKey[t1p1Key].doubles_lost;

I implemented similar changes (replacing singles_lost with doubles_lost) in lines 758-765 in js/source/tablechamp.js and that seems to have resolved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants