From f09580e2335fa85f5048cb90ff84dc23c769eb7c Mon Sep 17 00:00:00 2001 From: davemarco <83603688+davemarco@users.noreply.github.com> Date: Sun, 15 Sep 2024 12:30:41 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Junhao Liao --- new-log-viewer/src/components/Layout.tsx | 3 --- new-log-viewer/src/components/StatusBar/LogLevelFilter.tsx | 2 -- new-log-viewer/src/typings/worker.ts | 2 +- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/new-log-viewer/src/components/Layout.tsx b/new-log-viewer/src/components/Layout.tsx index 9a797d1d..c0169495 100644 --- a/new-log-viewer/src/components/Layout.tsx +++ b/new-log-viewer/src/components/Layout.tsx @@ -14,9 +14,6 @@ import APP_THEME from "./theme"; * * @return */ -// eslint-disable-next-line no-warning-comments -// TODO: replace elements in this component once we integrate with a UI framework -// eslint-disable-next-line max-lines-per-function const Layout = () => { return ( { const selected: LogLevelFilter = newValue && newValue.map((value) => Number(value)); - console.log(newValue); - setSelectedLogLevels(selected); changeLogLevelFilter(selected); }; diff --git a/new-log-viewer/src/typings/worker.ts b/new-log-viewer/src/typings/worker.ts index 3419005f..8135ea65 100644 --- a/new-log-viewer/src/typings/worker.ts +++ b/new-log-viewer/src/typings/worker.ts @@ -85,8 +85,8 @@ type WorkerRespMap = { }, [WORKER_RESP_CODE.VIEW_INFO]: { firstLogEventNumPerPage: number[], - numFilteredEvents: number, lastLogEventNumPerPage: number[], + numFilteredEvents: number, } };