Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some suggestions about Thread.sleep() #37

Open
o0lwj0o opened this issue May 14, 2019 · 0 comments
Open

Some suggestions about Thread.sleep() #37

o0lwj0o opened this issue May 14, 2019 · 0 comments

Comments

@o0lwj0o
Copy link

o0lwj0o commented May 14, 2019 •
edited
Loading

Hi, i found something in line 275-281
https://github.com/jobxhub/JobX/blob/master/jobx-agent/src/main/java/com/jobxhub/agent/bootstrap/JobXAgent.java

The code will wait for 'stopAwait' signal. It may cause potentially endless loop. I think use ‘CountDownLatch.await’ and set a max waitting time should be helpful.

Best Regards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@o0lwj0o