Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an upstream table for scan.ScanLocation #140

Open
CBroz1 opened this issue Feb 7, 2022 · 0 comments
Open

Add an upstream table for scan.ScanLocation #140

CBroz1 opened this issue Feb 7, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@CBroz1
Copy link
Contributor

CBroz1 commented Feb 7, 2022

The current pipeline imports element_lab.Location and then uses this as an upstream table for scan.ScanLocation which is described as follows:

Location: Reference table for ScanLocation, specifying the brain location where this scan is acquired

This does not match the description of element_lab.Location:

location of animal housing or experimental rigs

I propose modifying scan.ScanLocation to the following:

@schema
class ScanLocation(dj.Manual):
    definition = """
    -> Scan
    ---
    -> AnatomicalLocation
    """

And adding the following to workflow_calcium_imaging.pipeline.py or element_calcium_imaging.scan, changing the schema decorator:

@lab.schema
class AnatomicalLocation(dj.Manual):
    definition = """
    scan_location_id : varchar(16)
    ----
    anatomical_description: varchar(256)
    """
@CBroz1 CBroz1 added the bug Something isn't working label Feb 7, 2022
@kabilar kabilar removed the good first issue Good for newcomers label Mar 26, 2023
@kabilar kabilar transferred this issue from datajoint/workflow-calcium-imaging Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants