From e9a96a3a24571ddbf52ded423b4d2364ee9a46e8 Mon Sep 17 00:00:00 2001 From: skrydal Date: Tue, 7 May 2024 12:19:22 +0200 Subject: [PATCH 1/2] fix(ingestion): Explicitly set requirement on snowflake-connector-python to be newer or equal to 3.4.0 --- metadata-ingestion/setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metadata-ingestion/setup.py b/metadata-ingestion/setup.py index c9cbe66cdbca70..138955a7007680 100644 --- a/metadata-ingestion/setup.py +++ b/metadata-ingestion/setup.py @@ -194,7 +194,7 @@ # https://github.com/snowflakedb/snowflake-sqlalchemy/issues/350 "snowflake-sqlalchemy>=1.4.3", # See https://github.com/snowflakedb/snowflake-connector-python/pull/1348 for why 2.8.2 is blocked - "snowflake-connector-python!=2.8.2", + "snowflake-connector-python!=2.8.2,>=3.4.0", "pandas", "cryptography", "msal", From 9c06c771094c30d45391e76e4355a76c58a305a0 Mon Sep 17 00:00:00 2001 From: Harshal Sheth Date: Tue, 7 May 2024 22:04:03 -0700 Subject: [PATCH 2/2] Apply suggestions from code review --- metadata-ingestion/setup.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/metadata-ingestion/setup.py b/metadata-ingestion/setup.py index 138955a7007680..6e8b9c213c57c8 100644 --- a/metadata-ingestion/setup.py +++ b/metadata-ingestion/setup.py @@ -193,8 +193,7 @@ *sql_common, # https://github.com/snowflakedb/snowflake-sqlalchemy/issues/350 "snowflake-sqlalchemy>=1.4.3", - # See https://github.com/snowflakedb/snowflake-connector-python/pull/1348 for why 2.8.2 is blocked - "snowflake-connector-python!=2.8.2,>=3.4.0", + "snowflake-connector-python>=3.4.0", "pandas", "cryptography", "msal",