From 2390b284fba3286b77777c7fff593f1d48415081 Mon Sep 17 00:00:00 2001
From: David Leifker <david.leifker@acryl.io>
Date: Mon, 23 Dec 2024 17:40:29 -0600
Subject: [PATCH] fix(ci): further consolidate NODE_OPTIONS

---
 .github/workflows/build-and-test.yml |  2 --
 .github/workflows/docker-unified.yml |  2 --
 datahub-web-react/package.json       | 20 ++++++++++----------
 3 files changed, 10 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
index 98071b536a336..36097757a8cf5 100644
--- a/.github/workflows/build-and-test.yml
+++ b/.github/workflows/build-and-test.yml
@@ -109,8 +109,6 @@ jobs:
         if: ${{  matrix.command == 'frontend' && needs.setup.outputs.frontend_change == 'true' }}
         run: |
           ./gradlew :datahub-frontend:build :datahub-web-react:build --parallel
-        env:
-          NODE_OPTIONS: "--max-old-space-size=4096"
       - name: Gradle compile (jdk8) for legacy Spark
         if: ${{  matrix.command == 'except_metadata_ingestion' && needs.setup.outputs.backend_change == 'true' }}
         run: |
diff --git a/.github/workflows/docker-unified.yml b/.github/workflows/docker-unified.yml
index 03a9b3afc3bc5..ea7345c7220dc 100644
--- a/.github/workflows/docker-unified.yml
+++ b/.github/workflows/docker-unified.yml
@@ -445,8 +445,6 @@ jobs:
         run: |
           ./gradlew :datahub-frontend:dist -x test -x yarnTest -x yarnLint --parallel
           mv ./datahub-frontend/build/distributions/datahub-frontend-*.zip datahub-frontend.zip
-        env:
-          NODE_OPTIONS: "--max-old-space-size=4096"
       - name: Build and push
         uses: ./.github/actions/docker-custom-build-and-push
         with:
diff --git a/datahub-web-react/package.json b/datahub-web-react/package.json
index 2d1d667a89f14..61a6f70c57d34 100644
--- a/datahub-web-react/package.json
+++ b/datahub-web-react/package.json
@@ -87,20 +87,20 @@
         "yamljs": "^0.3.0"
     },
     "scripts": {
-        "analyze": "source-map-explorer 'dist/assets/*.js'",
-        "start": "yarn run generate && vite",
-        "ec2-dev": "yarn run generate && CI=true;export CI;vite",
-        "build": "yarn run generate && NODE_OPTIONS='--max-old-space-size=4096 --openssl-legacy-provider' CI=false vite build",
-        "test": "vitest",
-        "generate": "graphql-codegen --config codegen.yml",
+        "analyze": "NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' source-map-explorer 'dist/assets/*.js'",
+        "start": "NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' yarn run generate && NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' vite",
+        "ec2-dev": "NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' yarn run generate && CI=true NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' vite",
+        "build": "NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' yarn run generate && CI=false NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' vite build",
+        "test": "NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' vitest run --coverage",
+        "generate": "NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' graphql-codegen --config codegen.yml",
         "lint": "eslint . --ext .ts,.tsx --quiet && yarn format-check && yarn type-check",
-        "lint-fix": "eslint '*/**/*.{ts,tsx}' --quiet --fix && yarn format",
-        "format-check": "prettier --check src",
-        "format": "prettier --write src",
+        "lint-fix": "eslint '*/**/*.{ts,tsx}' --quiet --fix",
+        "format-check": "prettier --check ./src",
+        "format": "prettier --write ./src",
         "type-check": "tsc --noEmit",
         "type-watch": "tsc -w --noEmit",
         "storybook": "storybook dev -p 6006",
-        "build-storybook": "storybook build"
+        "build-storybook": "NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' storybook build"
     },
     "browserslist": {
         "production": [