Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom server type(s) #107

Open
jaagupviil opened this issue Nov 22, 2024 · 2 comments
Open

Custom server type(s) #107

jaagupviil opened this issue Nov 22, 2024 · 2 comments

Comments

@jaagupviil
Copy link

Currently the server type can only be one of the hard-coded values defined the schema:

servers:
  production:
    type: MyCustomServerType
    description: "Access point of the data x, y, z .. "
YAML [schema](https://datacontract.com/datacontract.schema.json) validation failed
Line 16: Value is not accepted. Valid values: "bigquery", "BigQuery", "s3", "sftp", "redshift", "azure", "sqlserver", "snowflake", "databricks", "dataframe", "glue", "postgres", "oracle", "kafka", "pubsub", "kinesis", "trino", "local".

It is understandable, that the predefined values make it easier for example to develop tooling around it, like datacontract-cli, but the datacontract-specification should be decoupled from this.
The contract should allow any custom type to specified (Kusto, SQLite, MariaDB, .., ..) - there will always be more types in the existence than a tool can support, but we should have a common language how we describe what data we offer, and from where.

@emirkmo
Copy link

emirkmo commented Dec 19, 2024

This has been a big issue for us during adoption. The specification is too tightly coupled to implementation provided in datacontract-cli, and this is one of the primary culprits (alongside quality).

@jochenchrist
Copy link
Contributor

I agree. Let's change the server.type to string (instead of the enum).

@simonharrer what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants