Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable schema validation #524

Closed
simonharrer opened this issue Nov 28, 2024 · 1 comment
Closed

Disable schema validation #524

simonharrer opened this issue Nov 28, 2024 · 1 comment

Comments

@simonharrer
Copy link
Contributor

Scenario:

  • Edit datacontract.yaml in VS Code
  • Visualize the contract on every change using DBML in VS Code

Issue:

  • Speed is crucial for a quick update when changing the YAML

Idea:

  • add parameter --schema-validation and --no-schema-validation to be able to disable schema validation so the generation of the DBML goes faster. We take into account that errors occur, and the resulting DBML is broken or cannot be produced.
@jochenchrist
Copy link
Contributor

Schema validation with fastjsonschema is ~80ms, including reading the bundled data contract schema.
I'll close this issue as not planned, as there are better options to optimize performance.

@jochenchrist jochenchrist closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants