Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch between the datacontract specification and the datacontract cli in relation to primary key fields #518

Closed
DiegoGCh opened this issue Nov 22, 2024 · 0 comments

Comments

@DiegoGCh
Copy link
Contributor

Hi!

In the datacontract-specification main README, the Field Object and its examples use primaryKey to indicate if the field is a primary key.

At first the primary key field was added as a field called primary. This change was introduced in this commit. Since then, on the release v1.1.0 it was later deprecated due to it changing to primaryKey.

Field Object - README.md
image

primary deprecation - datacontract.schema.json
image

But in the datacontract-cli repo, the sqlalchemy-converter still expects the primary key as a field named primary.

image

So when running a migration that uses this sqlachemy-converter with the primary key set as the datacontract-specification repo indicates, it fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants