This should be incorporated into arya

[mtimm]

Not sure why we need another standalone project for this (honestly I'm ashamed of myself for having AryaLogger be a standalone repo, eventually I want to fold it into arya proper).

Can you work with @paullesiak to incorporate webarya into the existing arya package maybe using setuptools extras so the dependency on flask is optional.

pip install arya[web]

Probably best to create a feature branch on arya to add it then it can be merged once done/tested.

Thanks!

[kecorbin]

I added the template files to the module itself vs external, this should make distribution much simpler. Have a look, and if you like I'll open a PR. datacenter/arya@master...kecorbin:master

[mtimm]

The point of using setuptools extras is that there is no reason to have a required dependency on flask if you have no desire to use it. I'll leave it to @paullesiak if he wants to go one way or the other but he was resistant to having other dependencies in the past.

[kecorbin]

this commit should allow pip install arya (without flask) or pip install arya[web] Maybe I'm missing something.

[mtimm]

Sorry, you aren't missing anything I'm multitasking too much and not paying attention to all the details like I normally would. Yes this does what I am suggesting. Thanks!

[kecorbin]

Okay, will wait for Paul to add his thoughts

Sent from my iPhone

On Jul 24, 2015, at 1:59 PM, Mike Timm <[email protected]mailto:[email protected]> wrote:

Sorry, you aren't missing anything I'm multitasking too much and not paying attention to all the details like I normally would. Yes this does what I am suggesting. Thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-124631512.

[paullesiak]

Originally I wanted to avoid the external dependency on cobra, since it wasn't commonly available. However now it's generally out there, so it doesn't make sense for that guideline. Fine to have whatever external dependency so long as people can get it from pypi

[mtimm]

I still think an dependency on Flask is a bit heavy and would prefer to have the [web] option. I don't see a need to force the installation of Flask for packages/libraries that depend on arya for example. I guess it depends on what you want @paullesiak should arya be a standalone script or a library or something else?

AryaLogger has no need for Flask for example.