-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: http handler support temp table. #16375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Sep 3, 2024
github-actions
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Sep 3, 2024
youngsofun
force-pushed
the
session
branch
3 times, most recently
from
September 3, 2024 07:16
4341290
to
cc185c2
Compare
SkyFan2002
reviewed
Sep 3, 2024
SkyFan2002
reviewed
Sep 3, 2024
Let's track progress of http handler and clients in #16310 |
SkyFan2002
reviewed
Sep 3, 2024
src/query/service/src/servers/http/v1/session/client_session_manager.rs
Outdated
Show resolved
Hide resolved
SkyFan2002
reviewed
Sep 3, 2024
SkyFan2002
approved these changes
Sep 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sep 3, 2024
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-query
Area: databend query
C-feature
Category: feature
lgtm
This PR has been approved by a maintainer
pr-feature
this PR introduces a new feature to the codebase
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
temp_tbl_mgr
into the global ClientSessionManager and inject it into the session object when the next query arrives.note for HTTP handler, will return error if want to create temp table but token is not used (we need logout to free resouces). waiting for databendlabs/bendsql#479 and modify to other clients
Tests
Type of change
This change is