You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The whole discussion around to_array is quite tricky, see #294 and #307 . One big difficulty is that for some libraries it can stay lazy (e.g. Dask has a lazy array), whereas for others it can't (polars LazyFrame doesn't have a to_numpy attribute)
Maybe we can temporarily park it, and try to address the more important (arguably) issue of what to do about
Because as far as I can tell, this call is problematic for all libraries other than purely eager ones. Even Dask, which was mentioned in #294 as an example of a library which can stay lazy in to_array, raises in the call above (see here).
Dask raises here, it doesn't do any implicit computation.
So...what do we do here? Maybe let's try resolving this one, and then return to to_array?
I'll hold off making suggestions this time, let's let the discussion roll
The text was updated successfully, but these errors were encountered:
This seems related to #305 and what ought to happen if __bool__ is called on a Scalar. Any solution should probably incorporate the lessons learned from the analogous discussion for the array-api. In #305 I try to argue for piggy-backing on the array-API which would move this problem out of the scope of the dataframe API 🪄 .
I think we've resolved this now - __bool__ forces computation or raises (implementation-dependent), and it may be necessary to call persist first (also implementation-dependent)
The whole discussion around
to_array
is quite tricky, see #294 and #307 . One big difficulty is that for some libraries it can stay lazy (e.g. Dask has a lazy array), whereas for others it can't (polars LazyFrame doesn't have ato_numpy
attribute)Maybe we can temporarily park it, and try to address the more important (arguably) issue of what to do about
Because as far as I can tell, this call is problematic for all libraries other than purely eager ones. Even Dask, which was mentioned in #294 as an example of a library which can stay lazy in
to_array
, raises in the call above (see here).Dask raises here, it doesn't do any implicit computation.
So...what do we do here? Maybe let's try resolving this one, and then return to
to_array
?I'll hold off making suggestions this time, let's let the discussion roll
The text was updated successfully, but these errors were encountered: