Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_matrix_norm incorrect sampling #114

Closed
bicycleman15 opened this issue Apr 19, 2022 · 1 comment · Fixed by #116
Closed

test_matrix_norm incorrect sampling #114

bicycleman15 opened this issue Apr 19, 2022 · 1 comment · Fixed by #116

Comments

@bicycleman15
Copy link

bicycleman15 commented Apr 19, 2022

ord=sampled_from([-float('inf'), -2, -2, 1, 2, float('inf'), 'fro', 'nuc']))

Shouldn't we also sample -1, right now we are sampling -2 twice, seems to me like one of those -2 should be -1. I might be wrong tho.

I am happy to make a PR for the same :)

@honno
Copy link
Member

honno commented Apr 19, 2022

Thanks for pointing this out @bicycleman15, yea you're right. Would hold of a PR incase @asmeurer was going to rework test_matrix_norm in #101 anywho. Eh I'll just fix it now heh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants