-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dask support #17
Comments
That probably makes sense to do. And in principle I think that this package can add support for any widely used array library. |
I think this is a good idea. The code in dask/dask#8750 could be used as a guide - happy to help. |
I probably won't prioritize work on this myself for now unless some downstream consumer library expresses a desire for Dask support here. But if you want to submit a pull request adding it I will be happy to review and merge it. The primary purpose of this library is to wrap existing libraries so that they more closely match the array API. This is preferable to using a separate namespace in the library itself because end-users can continue to use the existing array objects, and only the corresponding consumer library (like scipy or scikit-learn) would need to use this compat layer to make use of the uniform array API on it. |
For the record, as discussed in other PRs, I started experimenting with what would imply supporting dask in scikit-learn via the Array API spec.
See the discussion in: scikit-learn/scikit-learn#26724 |
BTW I'll be running a sprint on the array API next week at the SciPy conference sprints. If any of you will be present this could be a thing to sprint on. |
@asmeurer let me know if you give it a shot. It should be quite easy to adapt scikit-learn tests to also add Then it's a matter of running:
|
I'm not sure when I'll be able to work on this issue, but if someone else wants to work on implementing it I'll be happy to review/help with questions. |
cc @jrbourbeau (for awareness) |
This is moving now, xref gh-76. |
Dask support has been merged. Quite a lot of functionality is skipped in the tests, which maybe could be improved with further wrappers, though most of it will either need to be fixed upstream, or can never be supported in Dask. People should open new issues if they run into any missing or broken behavior with Dask. |
Should we add Dask as a supported library that we wrap? See dask/dask#8750 (comment). CC @tomwhite @jakirkham
The text was updated successfully, but these errors were encountered: