-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ DWDS ] Spawn DDS in a process rather than using package:dds #2466
Conversation
This is part of the effort to stop shipping DDS via Pub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple questions / suggestions
auto label is removed for dart-lang/webdev/2466, due to - The status or check suite unit_test; windows; Dart dev; PKG: dwds; `dart test --total-shards 3 --shard-index 1 --exclude-ta... has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
This is part of the effort to stop shipping DDS via Pub.