Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ DWDS ] Spawn DDS in a process rather than using package:dds #2466

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

bkonyi
Copy link
Collaborator

@bkonyi bkonyi commented Jul 31, 2024

This is part of the effort to stop shipping DDS via Pub.

This is part of the effort to stop shipping DDS via Pub.
Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple questions / suggestions

Copy link

auto-submit bot commented Aug 1, 2024

auto label is removed for dart-lang/webdev/2466, due to - The status or check suite unit_test; windows; Dart dev; PKG: dwds; `dart test --total-shards 3 --shard-index 1 --exclude-ta... has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot merged commit 15c1451 into main Aug 1, 2024
54 checks passed
@auto-submit auto-submit bot deleted the dds_to_process branch August 1, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants