Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we change the "AVOID lines longer than 80 characters" rule? #6142

Open
srawlins opened this issue Oct 10, 2024 · 2 comments
Open

Should we change the "AVOID lines longer than 80 characters" rule? #6142

srawlins opened this issue Oct 10, 2024 · 2 comments
Assignees
Labels
a.effective-dart Relates to the best practices explained in Effective Dart co.discussion Community discussion on a new feature or change to an existing feature e2-days Can complete in < 5 days of normal, not dedicated, work p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.

Comments

@srawlins
Copy link
Member

Effective Dart says AVOID lines longer than 80 characters.

But with dart-lang/dart_style#1571 and dart-lang/dart_style#1157, adding the ability to configure a page width, I'm wondering if this will change? Maybe not. I think it'd be good to record a formal decision either way.

@munificent

@parlough parlough added a.effective-dart Relates to the best practices explained in Effective Dart p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. e2-days Can complete in < 5 days of normal, not dedicated, work co.discussion Community discussion on a new feature or change to an existing feature labels Oct 11, 2024
@munificent
Copy link
Member

Good question!

Personally, I still think Dart code looks best at 80 columns, and having that page width encourage users to use concise names and not create hugely nested expressions. But reasonable people seem to disagree with that.

Probably the best thing is to simply remove that rule.

@parlough
Copy link
Member

As a note, we could also change the rule to a CONSIDER if it's still thought of as a valuable suggestion.

Or we could introduce a new rule to "PREFER a consistent page width" and suggest the default but link to the docs about configuring it for the project.

@MaryaBelanger MaryaBelanger self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.effective-dart Relates to the best practices explained in Effective Dart co.discussion Community discussion on a new feature or change to an existing feature e2-days Can complete in < 5 days of normal, not dedicated, work p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.
Projects
None yet
Development

No branches or pull requests

4 participants