Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider finding a formatter for scss files #8076

Open
jonasfj opened this issue Sep 25, 2024 · 2 comments
Open

Consider finding a formatter for scss files #8076

jonasfj opened this issue Sep 25, 2024 · 2 comments

Comments

@jonasfj
Copy link
Member

jonasfj commented Sep 25, 2024

I might have an extension in vscode I can't figure out, or vscode has formatting for scss files built-in.

Is this something we should consider enabling?

I'm not sure if there is a good formatting for SASS, and if so, if we need to configure settings etc.

I'm just noting that having automatic formatting isn't the worst idea, if it's easily available, and we all have the same settings. Of course if we risk having different settings, then it becomes a massive pain.

@isoos
Copy link
Collaborator

isoos commented Sep 26, 2024

I think the VSCode plugin uses this project:
https://github.com/beautifier/js-beautify

We should investigate how hard it would be to make a formatter using the parser and visitor from https://pub.dev/packages/csslib

@isoos
Copy link
Collaborator

isoos commented Nov 20, 2024

I've checked https://pub.dev/packages/sass_api and it seems to me that it has a great AST + visitor pattern that we could use to create a canonical format for our sass files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants