Add rule that super in an extension type member is an error
#3364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
approved these changes
Sep 21, 2023
eernstg
changed the title
super in an extension type member is an errorsuper in an extension type member is an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension type feature specification does not specify how to deal with
superwhen it is used in the body of a member declaration. This PR adds the rule that it is a compile-time error to do so.We should probably indicate a different way to specify this semantics. One possible approach is to invoke a constructor that does not perform any computations (
super.m()will then be something likeV3(this).m()), or using a cast ((this as V3).m()), or using an intermediate extension type (such that we can write a forwarding memberm2in a context where the redeclaration that gave rise to this need in the first place does not exist:V.mcallsVIntermediate.m2which callsV3.m).