Enable and fix new lints (dart-archive/convert#97)

dart-lang · Dec 19, 2023 · ba40400 · ba40400
1 parent 41149d2
commit ba40400
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 18 deletions.
diff --git a/pkgs/convert/CHANGELOG.md b/pkgs/convert/CHANGELOG.md
@@ -1,4 +1,4 @@
-## 3.1.2-dev
+## 3.1.2-wip
 
 - Require Dart 3.0
 - Add chunked decoding support (`startChunkedConversion`) for `CodePage`

diff --git a/pkgs/convert/analysis_options.yaml b/pkgs/convert/analysis_options.yaml
@@ -13,17 +13,12 @@ linter:
     - avoid_unused_constructor_parameters
     - avoid_void_async
     - cancel_subscriptions
-    - comment_references
     - literal_only_boolean_expressions
     - missing_whitespace_between_adjacent_strings
     - no_adjacent_strings_in_list
     - no_runtimeType_toString
     - package_api_docs
-    - prefer_const_constructors
     - prefer_const_declarations
     - prefer_expression_function_bodies
-    - prefer_relative_imports
-    - test_types_in_equals
     - unnecessary_await_in_return
     - use_string_buffers
-    - use_super_parameters
diff --git a/pkgs/convert/pubspec.yaml b/pkgs/convert/pubspec.yaml
@@ -1,17 +1,17 @@
 name: convert
-version: 3.1.2-dev
+version: 3.1.2-wip
 description: >-
   Utilities for converting between data representations.
   Provides a number of Sink, Codec, Decoder, and Encoder types.
 repository: https://github.com/dart-lang/convert
 
 environment:
-  sdk: '^3.0.0'
+  sdk: ^3.0.0
 
 dependencies:
   typed_data: ^1.3.0
 
 dev_dependencies:
   benchmark_harness: ^2.2.0
-  dart_flutter_team_lints: ^1.0.0
+  dart_flutter_team_lints: ^2.0.0
   test: ^1.17.0
diff --git a/pkgs/convert/test/hex_test.dart b/pkgs/convert/test/hex_test.dart
@@ -147,24 +147,24 @@ void main() {
         expect(results, isEmpty);
 
         sink.add('0');
-        expect(results, equals([[]]));
+        expect(results, equals([<Never>[]]));
 
         sink.add('');
-        expect(results, equals([[]]));
+        expect(results, equals([<Never>[]]));
 
         sink.add('0');
         expect(
             results,
             equals([
-              [],
+              <Never>[],
               [0x00]
             ]));
 
         sink.add('');
         expect(
             results,
             equals([
-              [],
+              <Never>[],
               [0x00]
             ]));
       });

diff --git a/pkgs/convert/test/percent_test.dart b/pkgs/convert/test/percent_test.dart
@@ -154,22 +154,22 @@ void main() {
         expect(results, isEmpty);
 
         sink.add('%');
-        expect(results, equals([[]]));
+        expect(results, equals([<Never>[]]));
 
         sink.add('');
-        expect(results, equals([[]]));
+        expect(results, equals([<Never>[]]));
 
         sink.add('2');
-        expect(results, equals([[]]));
+        expect(results, equals([<Never>[]]));
 
         sink.add('');
-        expect(results, equals([[]]));
+        expect(results, equals([<Never>[]]));
 
         sink.add('0');
         expect(
             results,
             equals([
-              [],
+              <Never>[],
               [0x20]
             ]));
       });