Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Update to latest lints, require Dart 3.3 #270

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Update to latest lints, require Dart 3.3 #270

merged 2 commits into from
Apr 17, 2024

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Apr 17, 2024

No description provided.

@kevmoo kevmoo requested a review from devoncarew April 17, 2024 21:39
@kevmoo kevmoo enabled auto-merge (squash) April 17, 2024 21:40
Also enable CI on main branch
.github/workflows/publish.yaml Show resolved Hide resolved
@@ -9,8 +9,8 @@ topics:
- cli

environment:
sdk: ^3.0.0
sdk: ^3.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need as late as 3.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my mind: it hurts NOTHING. Makes sure we're getting access to latest language features. Given how quickly our ecosystem moves forward, etc.

@kevmoo kevmoo merged commit e2e2023 into main Apr 17, 2024
6 checks passed
@kevmoo kevmoo deleted the lints branch April 17, 2024 22:00
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request May 20, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/5c83bc9..cf90551):
  cf90551  Fri May 3 11:17:38 2024 -0700  Devon Carew  blast_repo fixes (dart-archive/args#274)
  72d6ef0  Wed May 1 23:57:25 2024 +0000  dependabot[bot]  Bump actions/checkout from 4.1.2 to 4.1.4 (dart-archive/args#271)
  e2e2023  Wed Apr 17 15:00:21 2024 -0700  Kevin Moore  Update to latest lints, require Dart 3.3 (dart-archive/args#270)
  8d66d21  Mon Apr 15 15:29:55 2024 +0000  dependabot[bot]  Bump dart-lang/setup-dart from 1.6.2 to 1.6.4 (dart-archive/args#268)

http (https://github.com/dart-lang/http/compare/76deb75..5c01453):
  5c01453  Fri May 17 15:41:46 2024 -0700  Brian Quinlan  Create a fake WebSocket implementation (dart-lang/http#1200)
  4d2f9f9  Fri May 17 15:19:58 2024 -0700  Brian Quinlan  Get ready to publish cronet_http 1.2.1 (dart-lang/http#1202)

mockito (https://github.com/dart-lang/mockito/compare/4be52e1..2302814):
  2302814  Fri May 17 09:51:20 2024 -0700  Googler  Stop using deprecated LibraryElement.isNonNullableByDefault

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/8c77d6f..45b8ce9):
  45b8ce9  Fri May 17 15:19:29 2024 -0700  Brian Quinlan  Remove obsolete `WebSocketChannel.new` documentation. (dart-lang/web_socket_channel#363)

Change-Id: I654b0dce548e8b4ca1b98a626fddcb071cb1daae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367147
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants