Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid on-appear calls in tab views #3

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Fix invalid on-appear calls in tab views #3

wants to merge 7 commits into from

Commits on Apr 12, 2021

  1. Add onAppear actions

    @darrarski
    darrarski committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    81c6a1e View commit details
    Browse the repository at this point in the history

  2. Turn on debug for main reducer

    @darrarski
    darrarski committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    c0d577a View commit details
    Browse the repository at this point in the history

  3. Updated ComposableArchitecture dependency

    @darrarski
    darrarski committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    b711ce7 View commit details
    Browse the repository at this point in the history

  4. Add TabsViewState 

    This should prevent unneeded updates of the TabsView
    @darrarski
    darrarski committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    2c81ca8 View commit details
    Browse the repository at this point in the history

  5. Move .onAppear modifiers outside WithViewStore

    @darrarski
    darrarski committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    e93419a View commit details
    Browse the repository at this point in the history

  6. Add explicit Equatable conformance to Tab

    @darrarski
    darrarski committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    143dab8 View commit details
    Browse the repository at this point in the history

  7. Send onAppear actions from TabsView 

    Workaround, it works but I'm not sure why ¯\_(ツ)_/¯
    @darrarski
    darrarski committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    48e36d1 View commit details
    Browse the repository at this point in the history