Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles used for managed identities in AKS templates should be scoped down #214

Open
tmacam opened this issue Nov 9, 2023 · 0 comments
Open

Comments

@tmacam
Copy link
Contributor

tmacam commented Nov 9, 2023

In https://github.com/dapr/test-infra/blob/master/deploy/aks/monitoring/monitoring.bicep#L47-L55 we have the following:

resource grafanaRole 'Microsoft.Authorization/roleDefinitions@2022-04-01' existing = {
  name: '22926164-76b3-42b3-bc55-97df8dab3e41'
  scope: subscription()
}

resource amwRole 'Microsoft.Authorization/roleDefinitions@2022-04-01' existing = {
  name: 'b0d8363b-8ddd-447d-831f-62ca05bff136'
  scope: subscription()
}

This means that in order to deploy this bicep template you need permissions that grant you rights to create subscription-level roles. This is too broad, specially considering that the usage of these roles is scoped down to a single resource group / cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant