Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WORKFLOW SDK FEATURE REQUEST] more samples for dapr workflow #637

Closed
lucus-sun opened this issue Nov 16, 2023 · 5 comments
Closed

[WORKFLOW SDK FEATURE REQUEST] more samples for dapr workflow #637

lucus-sun opened this issue Nov 16, 2023 · 5 comments
Assignees
Labels
dapr-ext-workflow kind/enhancement New feature or request stale Issue marked as stale by Dapr Bot

Comments

@lucus-sun
Copy link

lucus-sun commented Nov 16, 2023

Describe the WORKFLOW SDK feature

We only have a basic workflow sample that call several activities one by one, it's hard to learn how to use other advanced features. We should have more example codes including:

  1. How to use durable timers in workflow?
  2. How to use child workflows?
  3. All these workflow patterns should be in the sample folder of the python sdk with a main function that can run directly.

Without these examples, it's very hard to learn how to use dapr workflow. Hope this can be scheduled in v1.13.

@cgillum
Copy link
Contributor

cgillum commented Nov 16, 2023

The workflow patterns examples have already been merged into this repo: #575.

You can find the workflow patterns samples here: https://github.com/dapr/python-sdk/tree/main/examples/workflow

I don't think there is currently a child workflow sample for Python, however. This is something that can be added.

@rabollin
Copy link

We do have multiple samples for Workflow scenarios in different repos that usually one can refer in addition to the pattern code samples shown in dapr docs here: https://docs.dapr.io/developing-applications/building-blocks/workflow/workflow-patterns/

Different DAPR repos where you can find the samples:

  1. https://github.com/dapr/samples
  2. https://github.com/dapr/python-sdk/tree/main/examples/workflow
  3. https://github.com/dapr/quickstarts

@cgillum
Copy link
Contributor

cgillum commented Nov 17, 2023

The Python Workflow demo that I created for KubeCon can be found here: https://github.com/dapr/samples/tree/master/workflow-orderprocessing-python

@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale Issue marked as stale by Dapr Bot label Jan 16, 2024
@dapr-bot
Copy link
Collaborator

This issue has been automatically closed because it has not had activity in the last 67 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@elena-kolevska elena-kolevska modified the milestone: v1.13 Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dapr-ext-workflow kind/enhancement New feature or request stale Issue marked as stale by Dapr Bot
Projects
None yet
Development

No branches or pull requests

6 participants