-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SpringBoot docs for new integrations #1123
Conversation
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
e1fa1f9
to
0c8b642
Compare
@artursouza @cicoyle please review :) |
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]>
} | ||
``` | ||
|
||
You can check and run the [full example source code here](https://github.com/salaboy/dapr-spring-boot-docs-examples). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically link to examples in the java-sdk so that they are maintained and kept updated. Is this example in the sdk and if not, can you add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cicoyle This is a bit different, as it uses Testcontainers and the intention here is to keep it as simple as possible for spring users to copy. Maybe we can have a separate directory for it inside the examples, but I wanted to make sure that this doesn't get all the dependencies from other examples that overly complicate it when users want to copy the project structure.
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text looks good to me, so Ill approve - still think we want this in the java-sdk or quickstarts: https://github.com/salaboy/dapr-spring-boot-docs-examples
cc @artursouza your thoughts ^?
Yes, we need them there. It can be a new PR. |
Description
Initial Spring Boot documentation added to the Java SDK Docs
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1122
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: