-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Dapr Container default wait strategy based on healthz/outbound #1105
Conversation
@artursouza and @cicoyle could you please take a look. This is required to make sure that we declare Dapr Testcontainer ready only when all the components are initialized. Thank you! |
Signed-off-by: Artur Ciocanu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment. LGTM.
Signed-off-by: Artur Ciocanu <[email protected]>
Fixed. |
@artursouza and @cicoyle the PR has been adjusted. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Adding Dapr Container default wait strategy based on healthz/outbound
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1104
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: