Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --resources-path instead of --components-path #1053

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

artur-ciocanu
Copy link
Contributor

@artur-ciocanu artur-ciocanu commented Jun 20, 2024

Description

This PR fixes the deprecated warning related to --components-path in the examples and replaces --components-path with --resources-path.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1052

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artur-ciocanu artur-ciocanu requested review from a team as code owners June 20, 2024 08:50
@artur-ciocanu artur-ciocanu force-pushed the fix-examples-dapr-flags branch 2 times, most recently from 3e66e7f to 26f75b9 Compare June 20, 2024 20:17
@artur-ciocanu
Copy link
Contributor Author

@artursouza and @cicoyle could you please take a look! Thank you!

It is not clear why some build steps are failing sometimes and others other time. I'll try to see if I can reproduce locally.

@cicoyle
Copy link
Contributor

cicoyle commented Jun 24, 2024

@artur-ciocanu mind resolving the conflicts. I don't think these kinds of errors are of concern: Could not find success criteria for command: dapr list and Im wondering if the other issues are transient.

@artur-ciocanu
Copy link
Contributor Author

@cicoyle and @artursouza I resolved the conflicts could you please take another look. Much appreciated!

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.79%. Comparing base (d759c53) to head (26f75b9).
Report is 22 commits behind head on master.

Current head 26f75b9 differs from pull request most recent head 1520fae

Please upload reports for the commit 1520fae to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1053      +/-   ##
============================================
+ Coverage     76.91%   77.79%   +0.88%     
+ Complexity     1592     1570      -22     
============================================
  Files           145      144       -1     
  Lines          4843     4797      -46     
  Branches        562      563       +1     
============================================
+ Hits           3725     3732       +7     
+ Misses          821      780      -41     
+ Partials        297      285      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artur-ciocanu
Copy link
Contributor Author

@cicoyle and @artursouza finally everything is 🟢 . Could you please take a look and merge! Thank you!

Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thx!

@artursouza artursouza added this to the v1.12 milestone Jun 25, 2024
@artursouza artursouza merged commit 48364b1 into dapr:master Jun 25, 2024
10 checks passed
@artur-ciocanu artur-ciocanu deleted the fix-examples-dapr-flags branch June 25, 2024 20:22
@marcduiker
Copy link
Contributor

@holopin-bot @artur-ciocanu Thank you!

Copy link

holopin-bot bot commented Aug 15, 2024

Congratulations @artur-ciocanu, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvaben335390clf7tjc0yc3

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update examples to use "--resources-path" instead of "--components-path"
4 participants