-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use --resources-path instead of --components-path #1053
Conversation
3e66e7f
to
26f75b9
Compare
@artursouza and @cicoyle could you please take a look! Thank you! It is not clear why some build steps are failing sometimes and others other time. I'll try to see if I can reproduce locally. |
@artur-ciocanu mind resolving the conflicts. I don't think these kinds of errors are of concern: |
26f75b9
to
b61be23
Compare
@cicoyle and @artursouza I resolved the conflicts could you please take another look. Much appreciated! |
53ea8dc
to
21b6629
Compare
Signed-off-by: Artur Ciocanu <[email protected]>
21b6629
to
1520fae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1053 +/- ##
============================================
+ Coverage 76.91% 77.79% +0.88%
+ Complexity 1592 1570 -22
============================================
Files 145 144 -1
Lines 4843 4797 -46
Branches 562 563 +1
============================================
+ Hits 3725 3732 +7
+ Misses 821 780 -41
+ Partials 297 285 -12 ☔ View full report in Codecov by Sentry. |
@cicoyle and @artursouza finally everything is 🟢 . Could you please take a look and merge! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thx!
@holopin-bot @artur-ciocanu Thank you! |
Congratulations @artur-ciocanu, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvaben335390clf7tjc0yc3 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
This PR fixes the deprecated warning related to
--components-path
in theexamples
and replaces--components-path
with--resources-path
.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1052
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: