Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] attach metadata to each individual message in bulkpublish if it exists #1437

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cwalsh2189
Copy link

Description

Currently the bulk publish metadata is only applied to the BulkPublishRequest object and not the individual messages within. Attaching the metadata to the individual messages as well so they can be applied when those are read.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1421

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • [] Extended the documentation

@cwalsh2189 cwalsh2189 requested review from a team as code owners January 6, 2025 21:42
@cwalsh2189
Copy link
Author

I was not sure what the full expectation for this change would be so wanted some feedback. It appears that this is impacting all consumers and not just Azure/Service Bus as in the open issue. We utilize AWS SNS/SQS and are seeing the same thing.

I went the route of applying the metadata to each individual message and leaving it at the top level, but not sure if that is still necessary/required, or if that piece should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client/pubsub kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service Bus: Bulk publish does not apply metadata properties to events
3 participants