From 56b69d09eae7201c473516958478206030317d90 Mon Sep 17 00:00:00 2001 From: Hannah Hunter Date: Wed, 28 Feb 2024 10:23:51 -0500 Subject: [PATCH 1/4] update to match code implementation Signed-off-by: Hannah Hunter --- .../supported-pubsub/setup-redis-pubsub.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md b/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md index 73b9cc00633..aff7ee46a79 100644 --- a/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md +++ b/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md @@ -43,8 +43,8 @@ The above example uses secrets as plain strings. It is recommended to use a secr | redisUsername | N | Username for Redis host. Defaults to empty. Make sure your redis server version is 6 or above, and have created acl rule correctly. | `""`, `"default"` | consumerID | N | The consumer group ID | `"myGroup"` | enableTLS | N | If the Redis instance supports TLS with public certificates, can be configured to be enabled or disabled. Defaults to `"false"` | `"true"`, `"false"` -| redeliverInterval | N | The interval between checking for pending messages to redelivery. Defaults to `"60s"`. `"0"` disables redelivery. | `"30s"` -| processingTimeout | N | The amount time a message must be pending before attempting to redeliver it. Defaults to `"15s"`. `"0"` disables redelivery. | `"30s"` +| redeliverInterval | N | The interval in milliseconds between checking for pending messages to redeliver. Defaults to `"60000"`. `"0"` disables redelivery. | `"5000"` +| processingTimeout | N | The amount time in milliseconds that a message must be pending before attempting to redeliver it. Defaults to `"15000"`. `"0"` disables redelivery. | `"600000"` | queueDepth | N | The size of the message queue for processing. Defaults to `"100"`. | `"1000"` | concurrency | N | The number of concurrent workers that are processing messages. Defaults to `"10"`. | `"15"` | redisType | N | The type of redis. There are two valid values, one is `"node"` for single node mode, the other is `"cluster"` for redis cluster mode. Defaults to `"node"`. | `"cluster"` From f2df1b3b6890a48d2a8a2f1113885cc6223c800d Mon Sep 17 00:00:00 2001 From: Hannah Hunter Date: Fri, 1 Mar 2024 11:54:53 -0500 Subject: [PATCH 2/4] update to include both seconds and milliseconds Signed-off-by: Hannah Hunter --- .../supported-pubsub/setup-redis-pubsub.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md b/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md index aff7ee46a79..04471ca5f11 100644 --- a/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md +++ b/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md @@ -43,8 +43,8 @@ The above example uses secrets as plain strings. It is recommended to use a secr | redisUsername | N | Username for Redis host. Defaults to empty. Make sure your redis server version is 6 or above, and have created acl rule correctly. | `""`, `"default"` | consumerID | N | The consumer group ID | `"myGroup"` | enableTLS | N | If the Redis instance supports TLS with public certificates, can be configured to be enabled or disabled. Defaults to `"false"` | `"true"`, `"false"` -| redeliverInterval | N | The interval in milliseconds between checking for pending messages to redeliver. Defaults to `"60000"`. `"0"` disables redelivery. | `"5000"` -| processingTimeout | N | The amount time in milliseconds that a message must be pending before attempting to redeliver it. Defaults to `"15000"`. `"0"` disables redelivery. | `"600000"` +| redeliverInterval | N | The interval between checking for pending messages to redeliver. Can use either seconds or milliseconds. Defaults to `"60s"`. `"0"` disables redelivery. | `"30s"`, `"5000"` +| processingTimeout | N | The amount time that a message must be pending before attempting to redeliver it. Can use either seconds or milliseconds. Defaults to `"15s"`. `"0"` disables redelivery. | `"30s"`, `"600000"` | queueDepth | N | The size of the message queue for processing. Defaults to `"100"`. | `"1000"` | concurrency | N | The number of concurrent workers that are processing messages. Defaults to `"10"`. | `"15"` | redisType | N | The type of redis. There are two valid values, one is `"node"` for single node mode, the other is `"cluster"` for redis cluster mode. Defaults to `"node"`. | `"cluster"` From 5ed84a91ab854500e365a65150582c391eb99caa Mon Sep 17 00:00:00 2001 From: Mark Fussell Date: Fri, 1 Mar 2024 15:20:37 -0800 Subject: [PATCH 3/4] Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md Signed-off-by: Mark Fussell --- .../components-reference/supported-pubsub/setup-redis-pubsub.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md b/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md index 04471ca5f11..3faf44283d5 100644 --- a/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md +++ b/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md @@ -43,7 +43,7 @@ The above example uses secrets as plain strings. It is recommended to use a secr | redisUsername | N | Username for Redis host. Defaults to empty. Make sure your redis server version is 6 or above, and have created acl rule correctly. | `""`, `"default"` | consumerID | N | The consumer group ID | `"myGroup"` | enableTLS | N | If the Redis instance supports TLS with public certificates, can be configured to be enabled or disabled. Defaults to `"false"` | `"true"`, `"false"` -| redeliverInterval | N | The interval between checking for pending messages to redeliver. Can use either seconds or milliseconds. Defaults to `"60s"`. `"0"` disables redelivery. | `"30s"`, `"5000"` +| redeliverInterval | N | The interval between checking for pending messages to redeliver. Can use either be Go duration string (for example "ms", "s", "m") or milliseconds number. Defaults to `"60s"`. `"0"` disables redelivery. | `"30s"`, `"5000"` | processingTimeout | N | The amount time that a message must be pending before attempting to redeliver it. Can use either seconds or milliseconds. Defaults to `"15s"`. `"0"` disables redelivery. | `"30s"`, `"600000"` | queueDepth | N | The size of the message queue for processing. Defaults to `"100"`. | `"1000"` | concurrency | N | The number of concurrent workers that are processing messages. Defaults to `"10"`. | `"15"` From cac450b651984c0ba56148ba5715e840b2c1c2be Mon Sep 17 00:00:00 2001 From: Mark Fussell Date: Fri, 1 Mar 2024 15:20:42 -0800 Subject: [PATCH 4/4] Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md Signed-off-by: Mark Fussell --- .../components-reference/supported-pubsub/setup-redis-pubsub.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md b/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md index 3faf44283d5..b833301b2ea 100644 --- a/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md +++ b/daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md @@ -44,7 +44,7 @@ The above example uses secrets as plain strings. It is recommended to use a secr | consumerID | N | The consumer group ID | `"myGroup"` | enableTLS | N | If the Redis instance supports TLS with public certificates, can be configured to be enabled or disabled. Defaults to `"false"` | `"true"`, `"false"` | redeliverInterval | N | The interval between checking for pending messages to redeliver. Can use either be Go duration string (for example "ms", "s", "m") or milliseconds number. Defaults to `"60s"`. `"0"` disables redelivery. | `"30s"`, `"5000"` -| processingTimeout | N | The amount time that a message must be pending before attempting to redeliver it. Can use either seconds or milliseconds. Defaults to `"15s"`. `"0"` disables redelivery. | `"30s"`, `"600000"` +| processingTimeout | N | The amount time that a message must be pending before attempting to redeliver it. Can use either be Go duration string ( for example "ms", "s", "m") or milliseconds number. Defaults to `"15s"`. `"0"` disables redelivery. | `"60s"`, `"600000"` | queueDepth | N | The size of the message queue for processing. Defaults to `"100"`. | `"1000"` | concurrency | N | The number of concurrent workers that are processing messages. Defaults to `"10"`. | `"15"` | redisType | N | The type of redis. There are two valid values, one is `"node"` for single node mode, the other is `"cluster"` for redis cluster mode. Defaults to `"node"`. | `"cluster"`