Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct metadata field limit in setup-azure-servicebus-topics #4368

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

ariddlestone
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

In 7a0fab7 text was incorrectly added to maxDeliveryCount instead of autoDeleteOnIdleInSec. This corrects both lines, adding the missing text to autoDeleteOnIdleInSec, and removing it from maxDeliveryCount.

Issue reference

None

@ariddlestone ariddlestone requested review from a team as code owners October 2, 2024 01:02
…ubsub/setup-azure-servicebus-topics.md

Signed-off-by: Mark Fussell <[email protected]>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @ariddlestone. Appreciate you making the docs better
LGTM. @hhunter-ms PTAL

@hhunter-ms hhunter-ms merged commit 3548a9b into dapr:v1.14 Oct 3, 2024
7 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @ariddlestone Thank you for your contribution!

Copy link

holopin-bot bot commented Oct 4, 2024

Congratulations @ariddlestone, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm1ukpy9316200dmeocs386wu

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants