Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add asb metadata based on PR dapr/components-contrib#2203 #3799

Merged
merged 7 commits into from
Oct 11, 2023

Conversation

mukundansundar
Copy link
Contributor

@mukundansundar mukundansundar commented Oct 9, 2023

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Based on PR dapr/components-contrib#2203

Details added based off of https://docs.dapr.io/reference/components-reference/supported-pubsub/setup-azure-servicebus-queues/#message-metadata

Issue reference

closes #1942

@mukundansundar mukundansundar requested review from a team as code owners October 9, 2023 09:26
@mukundansundar
Copy link
Contributor Author

@ItalyPaleAle Please review this PR.

Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some formatting edits

Signed-off-by: Mukundan Sundararajan <[email protected]>
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment per Alessandro's review

…indings/servicebusqueues.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Mukundan Sundararajan <[email protected]>
@hhunter-ms hhunter-ms merged commit 6d1e6c4 into dapr:v1.12 Oct 11, 2023
4 checks passed
@mukundansundar mukundansundar deleted the asb-metadata-bindings branch October 11, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants