Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Edit or Withdraw from addresses in MM that don't match checksum format #74

Open
andytudhope opened this issue Jan 28, 2020 · 4 comments

Comments

@andytudhope
Copy link
Collaborator

Currently, we store the Eth addresses associated with each DApp in the "old" form, i.e.

0xad2cebabcca6cc28226dffede5d43a82e061a366

However, most wallets (especially MetaMask) actually inject the checksum'd version of the address, i.e.

0xAD2ceBabCcA6CC28226DFFEdE5d43A82e061A366

This means that owners of the DApp who browse to our site using MM never see the "Edit" or "Withdraw" buttons at the bottom of their DApp's modal.

We need to make sure that the "Edit" and "Withdraw" buttons for each DApp work for either kind of address (given that different wallets do it differently). Ideally, it would only be on checksum'd addresses, but I think allowing both is more flexible UX for now.

@iamonuwa keen to handle this? If so, will create a bounty.

@andytudhope
Copy link
Collaborator Author

andytudhope commented Jan 28, 2020

It's weird though, I am struggling to replicate it... Seems fine in both Moz and Chrome for me.

And I'm unsure of the best way to fix it. Do we store the checksum'd address (which I think is better practice) and then check for both? Is there an easy way to do that? Needs more thought. The above examples come directly from one of the DApp owners who submitted and then could not edit. Changing to the checksum'd address in the DB then enabled them to edit.

@iamonuwa
Copy link
Contributor

I'll get back to you on this today🙏

@iamonuwa
Copy link
Contributor

Store checksum addresses I think is the best bet.

@andytudhope
Copy link
Collaborator Author

OK, let's do it.

  1. Can you replicate the issue?
  2. How long do you estimate it will take in hours?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants