Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to properly explain usage of package.json targets #4

Open
andytudhope opened this issue Jan 13, 2021 · 2 comments
Open

Comments

@andytudhope
Copy link
Collaborator

After cleaning up our dependencies and finding clarity on how we are integrating Embark (both contract objects and embark-js), we need to adjust the Makefile to build our new FE properly, zip it all up and make it pretty enough to simply drop into Amazon EB as we currently do.

This will require input from @jakubgs when we are ready with some of the other steps.

@jakubgs
Copy link
Collaborator

jakubgs commented Jan 13, 2021

After talking with Richard the most sensible thing to do would be probably to ditch the Makefile and re-doing the whole build process from scratch in something like Gulp/Grunt/Whatever. But to do that we'd have to essentially split the build process into it's distinct parts and make sure they work individually. Only then can we reliably combine them into a single pipeline.

@andytudhope andytudhope changed the title Clean Up Makefile Update README to properly explain usage of package.json targets Feb 3, 2021
@andytudhope
Copy link
Collaborator Author

We may still end up using the Makefile, but we need to update the README to explain clearly how to use which targets in package.json (including which version of node to use etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants