Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn solium problem on windows machines #215

Closed
tsuberim opened this issue Jan 3, 2018 · 7 comments
Closed

yarn solium problem on windows machines #215

tsuberim opened this issue Jan 3, 2018 · 7 comments

Comments

@tsuberim
Copy link
Contributor

tsuberim commented Jan 3, 2018

yarn solium lints incorrectly on windows.
image

@orenyodfat orenyodfat changed the title yarn solium problem no windows machines yarn solium problem on windows machines Jan 3, 2018
@orenyodfat
Copy link
Contributor

@dev-matan-tsuberi not sure it is windows issue.
It might be related to your editor setup .
check your tab/space setting.

@tsuberim
Copy link
Contributor Author

tsuberim commented Jan 3, 2018

@orenyodfat I actually tested this on a docker container running debian.

@orenyodfat
Copy link
Contributor

so how it is related to windows ?

@tsuberim
Copy link
Contributor Author

tsuberim commented Jan 3, 2018

No idea what exactly the problem is.
Seems to be an encoding issue according to @leviadam.
As I said, I ran it on debian without any issues. (generated only 5 warns)
Running on windows generates all these error and warns.

@orenyodfat
Copy link
Contributor

It might be known solium issue .
Take a look on this comment https://github.com/duaraghav8/Solium/blob/master/lib/cli.js#L172 .
It might worth to open an issue at solium and see what they say.
https://github.com/duaraghav8/Solium

@tsuberim
Copy link
Contributor Author

tsuberim commented Jan 3, 2018

opened issue on solium: duaraghav8/Ethlint#162

@leviadam
Copy link
Contributor

leviadam commented Jan 3, 2018

It is an encoding issue for sure. But it is on solium to solve it.
I do not see it as a problem as we are officially supporting only unix based development.

@leviadam leviadam closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants