Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreatedAt field type varies across entities #456

Open
namesty opened this issue May 3, 2020 · 1 comment
Open

CreatedAt field type varies across entities #456

namesty opened this issue May 3, 2020 · 1 comment

Comments

@namesty
Copy link

namesty commented May 3, 2020

Some entities like Reward, have the createdAt state attribute of type Date, which is a Javascript which is a JS global object. Others like Member have the same field, but of type Date, which is a type alias for number. Some others like Proposal have number | Date where Date is JS Date object.

This should be handled in a uniform way, and update the ItemMap methods and tests for this accordingly.

@dkent600
Copy link
Contributor

I second this request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants