Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make graphql be an external dependency in rollup #439

Open
dkent600 opened this issue Apr 2, 2020 · 0 comments
Open

make graphql be an external dependency in rollup #439

dkent600 opened this issue Apr 2, 2020 · 0 comments

Comments

@dkent600
Copy link
Contributor

dkent600 commented Apr 2, 2020

Underscore protocol only allows a single instance of graphql to be present. I believe that simply enforces a restriction of graphql itself. To provide the most options for dApps using multiple packages that each leverage graphql, the client lib can define graphql as an external dependency in the rollup configuration. Then if the dApp chooses to define graphql as a top-level dependency, it may, and as long as it means the client lib's own top-level dependency, the client lib will defer to that. Otherwise, client lib will us the version that it has defined as its own top-level dependency (just as it does now).

Thus I suggest that the client lib define graphql as an external dependency in its rollup configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant