Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out of memory building review app #1591

Closed
dkent600 opened this issue Apr 13, 2020 · 5 comments
Closed

out of memory building review app #1591

dkent600 opened this issue Apr 13, 2020 · 5 comments
Assignees

Comments

@dkent600
Copy link
Contributor

dkent600 commented Apr 13, 2020

This has returned:

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

This is happening in the current dev branch, thus we have no staging builds, and merging dev into any other branch will likely break their review apps too. Like this one:

https://github.com/daostack/alchemy/tree/fixTorusDoubleClick

@orenyodfat
Copy link
Contributor

this is due to #1578
please revert it back @dkent600

@dkent600
Copy link
Contributor Author

@orenyodfat can you please report here what you did here with heroku to workaround this? thanks

@dkent600 dkent600 self-assigned this Apr 15, 2020
@dkent600
Copy link
Contributor Author

I got the slug size back down to 391M without seeing the out-of-memory error by playing with the app config variables:

NODE_ENV staging
NPM_CONFIG_PRODUCTION true

These are set for all 4 staging sites plus all review sites

@orenyodfat orenyodfat reopened this Apr 15, 2020
@dkent600
Copy link
Contributor Author

dkent600 commented May 6, 2020

This continues to happen when we don't use the cheap-module-source-map, for example, this: #1553

@roienatan
Copy link
Contributor

Closing, looks like this problem was solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants