Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with Plasma-manager #485

Closed
urioTV opened this issue Jul 23, 2024 · 8 comments · Fixed by #490
Closed

Compatibility issue with Plasma-manager #485

urioTV opened this issue Jul 23, 2024 · 8 comments · Fixed by #490

Comments

@urioTV
Copy link

urioTV commented Jul 23, 2024

After update(not sure if it's an plasma-manager or stylix update) those two config-managers have a conflict on .config/kdeglobals. It completely breaks my config so I want to figure out where is the problem. I'll probably create the same issue on Stylix and Plasma-manager github.

@urioTV
Copy link
Author

urioTV commented Jul 23, 2024

Flake.lock without this problem. That's the last update when everything were working.


"stylix": {
      "inputs": {
        "base16": "base16",
        "base16-fish": "base16-fish",
        "base16-foot": "base16-foot",
        "base16-helix": "base16-helix",
        "base16-kitty": "base16-kitty",
        "base16-tmux": "base16-tmux",
        "base16-vim": "base16-vim",
        "flake-compat": "flake-compat_2",
        "gnome-shell": "gnome-shell",
        "home-manager": "home-manager_3",
        "nixpkgs": "nixpkgs_4"
      },
      "locked": {
        "lastModified": 1720818679,
        "narHash": "sha256-u9PqY7O6TN42SLeb0e6mnYAgQOoQmclaVSHfLKMpmu0=",
        "owner": "danth",
        "repo": "stylix",
        "rev": "29148118cc33f08b71058e1cda7ca017f5300b51",
        "type": "github"
      },
      "original": {
        "owner": "danth",
        "repo": "stylix",
        "type": "github"
      }
    }

"plasma-manager": {
      "inputs": {
        "home-manager": [
          "home-manager"
        ],
        "nixpkgs": [
          "nixpkgs"
        ]
      },
      "locked": {
        "lastModified": 1720992717,
        "narHash": "sha256-8j1bZVfKT1vJ0e+U7NYRNBG+DdBj5C/tpwe5krxT4/4=",
        "owner": "pjones",
        "repo": "plasma-manager",
        "rev": "460b48dc3dcd05df568e27cbb90581d23baec8dc",
        "type": "github"
      },
      "original": {
        "owner": "pjones",
        "repo": "plasma-manager",
        "type": "github"
      }
    }



@urioTV
Copy link
Author

urioTV commented Jul 23, 2024

Okay after some testing I'm pretty sure the problem is on Stylix part. Something must have change from rev 2914811 and now Stylix writes something to .config/kdeglobals.

@urioTV
Copy link
Author

urioTV commented Jul 23, 2024

Someone from plasma-manager said that it started from 6bbae4f commit. Is there any way to make it compatible with plasma-manager or is there a way to disable this specific functionality?

@trueNAHO
Copy link
Collaborator

Someone from plasma-manager said that it started from 6bbae4f commit.

Yes, unfortunately this commit has been repeatedly reported to cause problems:

Is there any way to make it compatible with plasma-manager or is there a way to disable this specific functionality?

Ensuring compatibility requires fixing 6bbae4f. Currently, to disable this patch you would sadly have to downgrade Stylix prior to 6bbae4f.

@Jackaed, @danth, should we revert 6bbae4f for now, as it is causing loads of problems?

@Jackaed
Copy link
Contributor

Jackaed commented Jul 24, 2024

@Jackaed, @danth, should we revert 6bbae4f for now, as it is causing loads of problems?

That seems like it might be sensible - I think we probably should try and talk to some people from KDE itself if possible to figure out what the "correct" way of trying to achieve our goals. My PR was a bit too based on "well it works for me" I think, there's probably a better way of going about things that I'm just not aware of.

@Jackaed
Copy link
Contributor

Jackaed commented Jul 24, 2024

I'm going to have a look at how plasma-manager does things with regards to the kdeglobals file - might be able to find a better way of doing things.

@danth
Copy link
Owner

danth commented Jul 24, 2024

Yes, I would agree with reverting for now. Having this commit in master for a while has at least helped to expose more issues which we hadn't even considered before, so we can develop a better solution before releasing again.

Also, while looking up the qt.plaformTheme option earlier, I noticed Home Manager has a set of kconfig options available which could be relevant, although their implementation looks like it's just calling a command for each individual option set.

Looking at plasma-manager seems like a good next step.

@HeitorAugustoLN
Copy link

I'm going to have a look at how plasma-manager does things with regards to the kdeglobals file - might be able to find a better way of doing things.

What is probably causing the issue here is the kdeglobals file being read-only.
We use our own script to write configuration to files.

trueNAHO added a commit to trueNAHO/stylix that referenced this issue Jul 25, 2024
Revert commit 6bbae4f ("kde: apply Qt theme on non-KDE systems and
add Qt6 support (danth#367)") due to unexpected issues.

Follow-up work is tracked in danth#480.

Closes: danth#480
Closes: danth#485
Closes: danth#487
trueNAHO added a commit to trueNAHO/stylix that referenced this issue Jul 25, 2024
Revert commit 6bbae4f ("kde: apply Qt theme on non-KDE systems and
add Qt6 support (danth#367)") due to unexpected issues.

Follow-up work is tracked in danth#489.

Closes: danth#480
Closes: danth#485
Closes: danth#487
@danth danth closed this as completed in b9de20c Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants