Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Agents - multi file upload erratic behaviour #4746

Closed
1 task done
thingersoft opened this issue Nov 18, 2024 · 1 comment · Fixed by #5159
Closed
1 task done

[Bug]: Agents - multi file upload erratic behaviour #4746

thingersoft opened this issue Nov 18, 2024 · 1 comment · Fixed by #5159
Labels
bug Something isn't working

Comments

@thingersoft
Copy link
Contributor

What happened?

Attaching multiple files at once in "file search" functionality causes erratic behaviour: the number of uploaded files doesn't match the number of selected files.

Steps to Reproduce

  1. configure RAG
  2. configure an agent
  3. enable file search for the agent
  4. select 5 documents to upload at once
  5. repeat step 4
  6. repeat step 4

You'll and up with n.13 documents associated with the agent

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Screenshots

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thingersoft thingersoft added the bug Something isn't working label Nov 18, 2024
thingersoft added a commit to thingersoft/LibreChat that referenced this issue Jan 1, 2025
@thingersoft
Copy link
Contributor Author

That's a concurrency issue.
Attaching multiple files at once triggers one request for each file.
On server side the agent update logic includes two async operations, one to retrieve the agent and the following to update it based on the previously retrieved data.
With multiple concurrent requests being processed the retrieved data can become stale, causing the reported issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant