Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log from worker subprocess, check if result_id is received #78

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yankovs
Copy link
Contributor

@yankovs yankovs commented Jun 10, 2024

Fixes #76

Should anything be done on the else branch in line 127? Maybe marking job as failed?

The issue with this context manager is that is on `__exit__` it marks the job either complete or sets an error. But in this case, the error happens inside a child process and isn't propagated to the calling process. So essentially, even if the subprocess set this job as failed, it will be overridden to be completed.
@danielplohmann
Copy link
Owner

Hey, I have a quick question:
Why is it needed to remove the context manager for the jobs?
Did that part break something or cause issues?
I'm asking because when jobs exit their context, they do some stuff, especially the complete() updates the queue collection counters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spawningworker: logging, check if process crashed
2 participants