Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove toJSON implementations if/when Jest can be made to render our types #441

Open
danfuzz opened this issue Nov 22, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@danfuzz
Copy link
Owner

danfuzz commented Nov 22, 2024

Describe the bug

The toJSON() implementations in this project only exist to help debug test cases, specifically so that expect(...).toEqual() (and similar) have a chance of rendering useful results when a test fails.

I filed Jest issue jestjs/jest#15386, which if addressed (or it turns out I missed a way to do the thing) would mean that the toJSON() methods won't be necessary anymore.

To reproduce

Steps to reproduce the problem:

  1. Look for toJSON() in the code.

Expected behavior

No results.

Actual behavior

Several results.

Environment

  • OS: n/a
  • Node: n/a
@danfuzz danfuzz added the bug Something isn't working label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant