Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad host error kinda gets swallowed with HTTP2 #160

Open
danfuzz opened this issue Mar 1, 2023 · 1 comment
Open

Bad host error kinda gets swallowed with HTTP2 #160

danfuzz opened this issue Mar 1, 2023 · 1 comment
Labels
bug Something isn't working framework Has something to do with the system framework

Comments

@danfuzz
Copy link
Owner

danfuzz commented Mar 1, 2023

Describe the bug
When a bogus Host header is passed to an HTTP2 request, the connection gets closed abruptly, but no error appears in the system log, and the connection/socket object seems to remain in some form.

To reproduce
Steps to reproduce the behavior:

  1. Build the system.
  2. Run the test configuration...
  3. In a terminal: curl --insecure -H 'Host: 123.4^56' https://localhost:8443/foo/bar

Expected behavior
An error shows up in the system log, and the connection gets properly closed.

Actual behavior
The connection actually gets closed, but there is no indication in the system log that anything is amiss. It's like the request is still being processed or something.

Environment

  • OS: macOs

Additional context
This does not seem to happen with an HTTPS request.

@danfuzz danfuzz added bug Something isn't working framework Has something to do with the system framework labels Mar 1, 2023
@danfuzz
Copy link
Owner Author

danfuzz commented Mar 10, 2024

It looks like the Node HTTP2 library is swallowing this and not reporting any event to client code. Unclear if there is anything to be done about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework Has something to do with the system framework
Projects
None yet
Development

No branches or pull requests

1 participant