You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #266 (comment)@candleindark identified oddity in our metadata records, that Affiliation records include fields which are not part of the Affiliation model, e.g.
where affiliations got their own Affiliation class. But migrate() function was not adjusted to filter them out somehow... but here we do not even need explicit migration since pydantic likely to do the right thing:
which would forbid us to validate using more strict models such as the ones disallowing for extra fields, but also potentially simply having "bugs" due to migration not carried out at all.
On the side of dandi-schema I would like us to check what would happen if we .migrate() metadata records for dandisets -- would they succeed/fail and get rid of those irrelevant values.
The text was updated successfully, but these errors were encountered:
Per @yarikoptic suggestion, generate a basic table that go through all the public dandisets and print the validation statuses of both before and after the .migrate() function.
In #266 (comment) @candleindark identified oddity in our metadata records, that Affiliation records include fields which are not part of the Affiliation model, e.g.
https://api.dandiarchive.org/api/dandisets/000029/versions/draft/info/ ATM has
after doing archeological metadata expedition we figured that it is 99% likely due to
where affiliations got their own Affiliation class. But
migrate()
function was not adjusted to filter them out somehow... but here we do not even need explicit migration since pydantic likely to do the right thing:and here is with the full
so the hypothesis that absence of metadata migration on dandi-archive side, ref:
keeps old metadata versions present, and it is so:
which would forbid us to validate using more strict models such as the ones disallowing for extra fields, but also potentially simply having "bugs" due to migration not carried out at all.
On the side of dandi-schema I would like us to check what would happen if we
.migrate()
metadata records for dandisets -- would they succeed/fail and get rid of those irrelevant values.The text was updated successfully, but these errors were encountered: